On Tue, May 15, 2018 at 04:50:04PM +0300, Amir Goldstein wrote: > On Tue, May 15, 2018 at 8:25 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > On Tue, May 15, 2018 at 2:01 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > >> On Mon, May 14, 2018 at 08:49:49AM +0300, Amir Goldstein wrote: > >>> This is what all other tests use as well as _require_freeze > >>> > >>> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > >>> --- > [...] > >> > >> Shouldn't these all be converted to XFS_FREEZE_PROG w/ a setup call > >> to export XFS_FREEZE_PROG="`set_prog_path xfs_freeze`"? > >> > > > > Yeh, I suppose I can take this one as part of the "freeze" cleanup. > > > > I looked again and xfs_freeze pattern repeats itself quite often with > other xfs_* progs, so I guess I'll leave that cleanup for another time... No worries, just add it to the pile... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx