Theodore Y. Ts'o wrote: > On Sun, May 06, 2018 at 02:03:57PM +0900, Tetsuo Handa wrote: > > > > Since syzbot is hitting this error path inside mount() request, calling > > panic() when something went wrong inside mount() request might be > > overkill. We can recover without shutting down the system, can't we? > > We could add a full kernel-mode fsck which gets run before mount --- > the question is how much complexity we want to add. If SELinux is > enabled, then we have to check xattr consinsistency, etc., etc. You are thinking too complicated. I'm not asking for kernel-mode fsck. I'm just suggesting that mount() request returns an error to the caller (and the administrator invokes fsck etc. as needed). We are fixing bugs which occur during mount operation (e.g. https://groups.google.com/d/msg/syzkaller-bugs/Yp4q8n-MijM/yDX3zl1XBQAJ https://groups.google.com/d/msg/syzkaller-bugs/4C4oiBX8vZ0/W6pi8NdbBgAJ https://groups.google.com/d/msg/syzkaller-bugs/QBnHAQBy2pI/ccf-yL5bBgAJ ). And extX filesystem is different from other filesystems that it invokes error action specified by errors= parameter rather than return an error to the caller.
