On Wed, Mar 07, 2018 at 09:53:36PM -0800, Tyson Nottingham wrote: > Previously, /proc/fs/ext4/<dev>/options would only show binary options > if they were set (1 in the options bit mask). E.g. it would show "grpid" > if it was set, but it would not show "nogrpid" if grpid was not set. > > This seems sensible, but when an option is absent from the file, it can > be hard for the unfamiliar to know what is being used. E.g. if there > isn't a (no)grpid entry, nogrpid is in effect. But if there isn't a > (no)auto_da_alloc entry, auto_da_alloc is in effect. If there isn't a > (minixdf|bsddf) entry, it turns out bsddf is in effect. It all depends > on how the option is implemented. > > It's clearer to be explicit, so print the corresponding option > regardless of whether it means a 1 or a 0 in the bit mask. > > Note that options which do not have an explicit disable option aren't > indicated as being disabled even with this change (e.g. dax). > > Signed-off-by: Tyson Nottingham <tgnottingham@xxxxxxxxx> Applied, thanks. - Ted
