On Thu, Mar 29, 2018 at 11:09 AM, Christoph Hellwig <hch@xxxxxx> wrote: > On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: >> So ext4_direct_IO() for IS_DAX() files will just bail out. So could you >> just provide ext4_dax_direct_IO() which will bail out and use it here? With >> a similar comment as in xfs_vm_direct_IO() that open still needs this >> method set... Thanks! > > In fact a common noop_direct_IO might make sense. Ok, I introduced noop_direct_IO() in "fs, dax: prepare for dax-specific address_space_operations", and cleaned up xfs, ext4, and ext2 accordingly. Let me know if you want to see a resend of the series with those changes. Otherwise this will appear in -next shortly.
