[Bug 199185] Invalid pointer dereference in get_acl (fs/posix_acl.c) when mounting and operating crafted ext4 image

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.kernel.org/show_bug.cgi?id=199185

Eric Biggers (ebiggers3@xxxxxxxxx) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebiggers3@xxxxxxxxx

--- Comment #4 from Eric Biggers (ebiggers3@xxxxxxxxx) ---
The above patch is wrong; it makes ext4_get_acl() always fail with ERANGE,
because ext4_get_acl() uses buffer=NULL and buffer_size=0 to get the size of
the xattr.  Likewise getxattr(..., NULL, 0) is broken.  I think we should check
'size' against XATTR_SIZE_MAX in the !buffer case instead.  Also checking 'size
< 0' is unnecessary since 'size' is unsigned.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux