On Tue, Mar 06, 2018 at 06:10:41PM +0100, Jan Kara wrote: > Is it really correct that once the filesystem gets shutdown you clear the > previous error from the journal? Because if we hit some real fs corruption, > the journal gets aborted, and then someone calls ext4_shutdown(), we'd > clear that error which looks like a bug to me because that shutdown hardly > fixes the fs corruption... That's not what the code does. If journal->j_errno is set, then we won't clear it, for precisely what concern you've articulated. - Ted