On Fri, Mar 09, 2018 at 12:12:04PM -0700, Andreas Dilger wrote: > > Rather than using 0xffffff directly, it makes sense to add something like: > > #define EXT4_DX_BLOCK_MASK 0x0fffffff > > and use this in both the kernel and e2fsprogs? I checked the rest of e2fsprogs > and it looks like this is the only place where this mask is used. Makes sense to me. I'll apply this patch with this change. Also, this mask is actually used in one more place, in parse_int_node(): blk = ext2fs_le32_to_cpu(ent[i].block) & 0x0ffffff; I'll fix that up too. - Ted
