Re: [e2fsprogs PATCH] blkid: fix building e2fsprogs with internal libblkid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 01, 2018 at 09:21:35PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Building e2fsprogs with the internal libblkid fails for me with the
> following compiler error:
> 
> 	In file included from blkidP.h:27:0,
> 			 from dev.c:17:
> 	dev.c: In function ‘blkid_free_dev’:
> 	../../lib/blkid/list.h:149:42: error: ‘intptr_t’ undeclared (first use in this function); did you mean ‘__intptr_t’?
> 	  ((type *)((char *)(ptr)-(unsigned long)(intptr_t)(&((type *)0)->member)))
> 
> The problem is that lib/blkid/list.h is now using 'intptr_t', but
> stdint.h is not guaranteed to have been included yet.  Include it.
> 
> Fixes: 0a3d8041892c ("AOSP: build mke2fs for windows using android mingw library")
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks for pointing this out!  I've fixed slightly modified your patch
to try using inttypes.h preferentially and to use HAVE_xxx_H #ifdefs,
e.g:

#ifdef HAVE_INTTYPES_H
#include <inttypes.h>
#else
#ifdef HAVE_STDINT_H
#include <stdint.h>
#endif
#endif

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux