On Thu, Jan 18, 2018 at 12:23:43PM +0800, Eryu Guan wrote: > On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote: > > generic/347 currently fails when run in cojunction with the DAX mount > > option: > > > > generic/347 72s ... - output mismatch (see > > /root/project/xfstests/results//generic/347.out.bad) > > --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600 > > +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17 > > 16:04:33.459348448 -0700 > > @@ -1,2 +1,3 @@ > > QA output created by 347 > > +mount: /mnt/xfstests_scratch: can't read superblock on > > /dev/mapper/thin-vol. > > === completed > > ... > > (Run 'diff -u tests/generic/347.out > > /root/project/xfstests/results//generic/347.out.bad' to see the entire > > diff) > > > > This is expected because the dm-thin target currently lacks DAX support. > > > > Just skip this test if we are using DAX. > > > > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> > > --- > > tests/generic/347 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/generic/347 b/tests/generic/347 > > index 3adc6744..0c2dec98 100755 > > --- a/tests/generic/347 > > +++ b/tests/generic/347 > > @@ -72,6 +72,7 @@ _supported_fs generic > > _supported_os Linux > > _require_scratch_nocheck > > _require_dm_target thin-pool > > +_exclude_scratch_mount_option dax > > IMHO, it'd be better to put this in common/dmthin file, as what's done > in common/dmerror or common/dmflakey (we grep for dax directly there, > that's because they've been added before _exclude_scratch_mount_option > was introduced), so all thinp tests are excluded from dax tests. Sure, will do. Thanks for the review.
