On Tue 09-01-18 20:37:54, piaojun wrote: > destroy_workqueue() will do flushing work for us. > > Signed-off-by: Jun Piao <piaojun@xxxxxxxxxx> Looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Adding Ted to CC as a maintainer... Honza > --- > fs/ext4/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 0556cd0..2f46b0b 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb) > ext4_unregister_li_request(sb); > ext4_quota_off_umount(sb); > > - flush_workqueue(sbi->rsv_conversion_wq); > destroy_workqueue(sbi->rsv_conversion_wq); > > if (sbi->s_journal) { > -- -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR