On Fri 22-12-17 18:54:57, Jeff Layton wrote: > On Sat, 2017-12-23 at 10:14 +1100, NeilBrown wrote: > > > +#include <linux/fs.h> > > > + > > > +/* > > > + * The change attribute (i_version) is mandated by NFSv4 and is mostly for > > > + * knfsd, but is also used for other purposes (e.g. IMA). The i_version must > > > + * appear different to observers if there was a change to the inode's data or > > > + * metadata since it was last queried. > > > + * > > > + * It should be considered an opaque value by observers. If it remains the same > > > > ^^^^^^^^^^^^ > > > > You keep using that word ... I don't think it means what you think it > > means. > > Change that sentence to: > > > > Observers see i_version as a 64 number which never decreases. > > > > and the rest still makes perfect sense. > > > > Thanks! Fixed in my tree. I'll not resend the set just for that though. With this fixed the patch looks good to me. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
