On Thu, Dec 14, 2017 at 03:13:15PM +0800, Zhouyi Zhou wrote: > Hi, > In function __ext4_grp_locked_error, __save_error_info(sb, function, line) > is called to save error info in super block block, but does not sync > that information > to disk to info the subsequence fsck after reboot. The reason, I guess > maybe it is > in locked state. > My question is why not make a call ext4_commit_super(sb, 1) after > ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck > after reboot is sure to be well informed. Adding ext4_commit_super(sb, 1) between the calls to ext4_unlock_group() and ext4_handle_error() is a good idea; it's not a naive suggestion at all. Cheers, - Ted
