On Wed, Dec 13, 2017 at 04:47:14PM -0700, Andreas Dilger wrote:
> Several recently-added fields in struct ext2_super_block were
> not being swabbed in ext2fs_swap_super(), in particular:
>
> s_raid_stride, s_raid_stripe_width, s_{first,last}_error_*
> s_lpf_ino, s_prj_quota_inum
>
> Add swabbing for these missing fields. Reorder the swabbing
> on other fields so that they are in struct order, and add
> comments for fields that do not need swabbing, so it is easier
> to see that all fields are being handled.
>
> Since this seems to be a fairly common occurrence, add compile
> time checks to ext2fs_swap_super(), ext2fs_swap_inode_large(),
> and ext2fs_swap_group_desc2() via a new EXT2FS_BUILD_BUG_ON()
> macro to cause a compile warning if fields are used from these
> structs without a corresponding change to the swab functions.
>
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Reported-by: Artem Blagodarenko <artem.blagodarenko@xxxxxxxxx>
> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxx>
Applied, thanks.
- Ted
