Re: [PATCH v2 4/7] debugfs: 64bit inode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 14, 2017, at 12:04 AM, Artem Blagodarenko <artem.blagodarenko@xxxxxxxxx> wrote:
> 
> New dirdata type EXT2_DIRENT_INODE is added.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@xxxxxxxxx>
> ---
> debugfs/ls.c         | 6 ++++--
> lib/ext2fs/ext2_fs.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/debugfs/ls.c b/debugfs/ls.c
> index 5655933e..b67c0800 100644
> --- a/debugfs/ls.c
> +++ b/debugfs/ls.c
> @@ -64,11 +64,13 @@ static void list_dirdata(struct list_dir_struct *ls,
> 
> 		dlen = data[0];
> 
> -		if (dirdata_mask == EXT2_DIRENT_LUFID) {
> +		if (dirdata_mask == EXT2_DIRENT_INODE)
> +			fprintf(ls->f, "ino64:%04\n", *(__u32 *)(data + 1));
> +		else if (dirdata_mask == EXT2_DIRENT_LUFID) {

(style) add {} around first part of if/else if needed on any part.

Looks fine otherwise.  You could add my:

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

Cheers, Andreas





Attachment: signature.asc
Description: Message signed with OpenPGP


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux