Re: [PATCH] fs, dax: unify IOMAP_F_DIRTY read vs write handling policy in the dax core

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> -	if ((flags & IOMAP_WRITE) && xfs_ipincount(ip) &&
> -	    (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP))
> -		iomap->flags |= IOMAP_F_DIRTY;
> +	if (xfs_ipincount(ip))
> +		if (ip->i_itemp->ili_fsync_fields & ~XFS_ILOG_TIMESTAMP)
> +			iomap->flags |= IOMAP_F_DIRTY;

Please don't split up the conditional and make it harder to read.

With that fixed up this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>