On Fri, Sep 08, 2017 at 08:12:01AM +1000, Dave Chinner wrote: > On Thu, Sep 07, 2017 at 03:51:48PM -0600, Ross Zwisler wrote: > > On Thu, Sep 07, 2017 at 03:26:10PM -0600, Andreas Dilger wrote: > > > However, I wonder if this could > > > be prevented at runtime, and only allow S_DAX to be set when the inode is > > > first instantiated, and wouldn't be allowed to change after that? Setting > > > or clearing the per-inode DAX flag might still be allowed, but it wouldn't > > > be enabled until the inode is next fetched into cache? Similarly, for > > > inodes that have conflicting features (e.g. inline data or encryption) > > > would not be allowed to enable S_DAX. > > > > Ooh, this seems interesting. This would ensure that S_DAX transitions > > couldn't ever race with I/Os or mmaps(). I had some other ideas for how to > > handle this, but I think your idea is more promising. :) > > IMO, that's an awful admin interface - it can't be done on demand > (i.e. when needed) because we can't force an inode to be evicted > from the cache. And then we have the "why the hell did that just > change" problem if an inode is evicted due to memory pressure and > then immediately reinstantiated by the running workload. That's a > recipe for driving admins insane... > > > I guess with this solution we'd need: > > > > a) A good way of letting the user detect the state where they had set the DAX > > inode flag, but that it wasn't yet in use by the inode. > > > > b) A reliable way of flushing the inode from the filesystem cache, so that the > > next time an open() happens they get the new behavior. The way I usually do > > this is via umount/remount, but there is probably already a way to do this? > > Not if it's referenced. And if it's not referenced, then the only > hammer we have is Brutus^Wdrop_caches. That's not an option for > production machines. > > Neat idea, but one I'd already thought of and discarded as "not > practical from an admin perspective". Okay, so other ideas (which you have also probably already though of) include: 1) Just return -EBUSY if anyone tries to change the DAX flag of an inode with open mappings or any open file handles. To prevent TOCTOU races we'd have to do some additional locking while actually changing the flag. 2) Be more drastic and follow the flow of ext4 file based encryption, only allowing the inode flag to be set by an admin on an empty directory. Files in that directory will inherit it when they are created, and we don't provide a way to clear. If you want your file to not use DAX, move it to a different directory (which I think for ext4 encryption turns it into a new inode). Other ideas?
