Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 30, 2017 at 11:03:08PM +0200, Arnd Bergmann wrote:
> On Fri, Aug 25, 2017 at 8:48 PM, Andreas Dilger <adilger@xxxxxxxxx> wrote:
> > Avoid a 32-bit time overflow in recently_deleted() since i_dtime
> > (inode deletion time) is stored only as a 32-bit value on disk.
> > Since i_dtime isn't used for much beyond a boolean value in e2fsck
> > and is otherwise only used in this function in the kernel, there is
> > no benefit to use more space in the inode for this field on disk.
> >
> > Instead, compare only the relative deletion time with the low
> > 32 bits of the time using the newly-added time_before32() helper,
> > which is similar to time_before() and time_after() for jiffies.
> >
> > Increase RECENTCY_DIRTY to 300s based on Ted's comments about
> > usage experience at Google.
> >
> > Signed-off-by: Andreas Dilger <adilger@xxxxxxxxx>
> > Change-Id: I7402e1b3d49ea326f872ec8324933f42b502b9be
> 
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks, applied.

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux