On Wed, Aug 23, 2017 at 12:00:00PM +0200, Jan Kara wrote: > On Wed 23-08-17 17:13:57, zhangyi (F) wrote: > > Current ext4 quota should always "usage enabled" if the > > quota feautre is enabled. But in ext4_orphan_cleanup(), it > > turn quotas off directly (used for the older journaled > > quota), so we cannot turn it on again via "quotaon" unless > > umount and remount ext4. > > > > Simple reproduce: > > > > mkfs.ext4 -O project,quota /dev/vdb1 > > mount -o prjquota /dev/vdb1 /mnt > > chattr -p 123 /mnt > > chattr +P /mnt > > touch /mnt/aa /mnt/bb > > exec 100<>/mnt/aa > > rm -f /mnt/aa > > sync > > echo c > /proc/sysrq-trigger > > > > #reboot and mount > > mount -o prjquota /dev/vdb1 /mnt > > #query status > > quotaon -Ppv /dev/vdb1 > > #output > > quotaon: Cannot find mountpoint for device /dev/vdb1 > > quotaon: No correct mountpoint specified. > > > > This patch add check for journaled quotas to avoid incorrect > > quotaoff when ext4 has quota feautre. > > > > Signed-off-by: zhangyi (F) <yi.zhang@xxxxxxxxxx> > > Looks good. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks, applied. - Ted
