Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
From: "Theodore Ts'o" <tytso@xxxxxxx>
Date: Thu, 24 Aug 2017 13:44:45 -0400
Cc: Eric Sandeen <esandeen@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Andreas Dilger <adilger.kernel@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <e522d9a5-4d5a-b4a1-fe94-bb3aae4c5976@users.sourceforge.net>
Mail-followup-to: Theodore Ts'o <tytso@xxxxxxx>, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>, Eric Sandeen <esandeen@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Andreas Dilger <adilger.kernel@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx
References: <ca49a6dc-f2ee-d427-5f16-052706277b38@users.sourceforge.net> <5bf432ae-398d-718c-8105-3092a240a8ef@users.sourceforge.net> <b21f6c3d-2cad-3f72-f410-f608ea5f4cea@redhat.com> <e522d9a5-4d5a-b4a1-fe94-bb3aae4c5976@users.sourceforge.net>
User-agent: NeoMutt/20170609 (1.8.3)

On Sat, Aug 19, 2017 at 08:00:31PM +0200, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> > 
> > I might be dense, but what makes this message "extra?"
> > 
> > (I suppose kmalloc squawks too if it fails,
> 
> Do you find the default allocation failure report sufficient?

>From a helpdesk reporting situation, having a more specific message
when there is a MMP failure causing the mount to fail is definitely
useful.

So, NACK.

					- Ted

References:
- [PATCH 0/2] fs-ext4: Adjustments for two function implementations
  - From: SF Markus Elfring
- [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
  - From: SF Markus Elfring
- Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
  - From: Eric Sandeen
- Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
  - From: SF Markus Elfring

Prev by Date: Re: [PATCH] ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets
Next by Date: Re: [PATCH 2/2] ext4: Improve a size determination in two functions
Previous by thread: Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Next by thread: Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]