Re: [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite
From: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Date: Fri, 18 Aug 2017 16:10:32 -0600
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Boaz Harrosh <boazh@xxxxxxxxxx>
In-reply-to: <20170817160815.30466-7-jack@suse.cz>
Mail-followup-to: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Boaz Harrosh <boazh@xxxxxxxxxx>
References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-7-jack@suse.cz>
User-agent: Mutt/1.8.3 (2017-05-23)

On Thu, Aug 17, 2017 at 06:08:08PM +0200, Jan Kara wrote:
> dax_insert_mapping() has only one callsite and we will need to further
> fine tune what it does for synchronous faults. Just inline it into the
> callsite so that we don't have to pass awkward bools around.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Looks good.

Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

References:
- [RFC PATCH 0/13 v2] dax, ext4: Synchronous page faults
  - From: Jan Kara
- [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite
  - From: Jan Kara

Prev by Date: Re: [PATCH 05/13] dax: Create local variable for vmf->flags & FAULT_FLAG_WRITE test
Next by Date: Re: [PATCH 07/13] dax: Inline dax_pmd_insert_mapping() into the callsite
Previous by thread: [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite
Next by thread: Re: [PATCH 06/13] dax: Inline dax_insert_mapping() into the callsite
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]