Re: [PATCH] resize2fs: add support for resizing filesystems with ea_inode feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 14, 2017 at 05:38:49PM -0700, Tahsin Erdogan wrote:
> Resizing filesystems with ea_inode feature was disallowed so far
> because the code for updating the ea entries was missing. This patch
> adds that support.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@xxxxxxxxxx>

Thanks, applied.  I do have a few comments; if you can look into
providing some test cases, that would be great.  Also, although this
isn't first change that we've added to resize2fs which has this
property, it used to be that if resize2fs was interrupted, the user
could usually recover by running e2fsck.  With ea_inode, there will be
cases where resize2fs getting interrupted could result in the file
system's extended attributes getting pretty badly scrambled.

Using an undo file is one way to solve the problem; so perhaps
something we should consider is making the undo file enabled by
default.  (Although then we need to figure out where to put it; the
current directory might not be the right place, especially if it
happens to be /tmp.)

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux