On Wed, Jul 19, 2017 at 10:42:20AM -0400, Theodore Ts'o wrote: > On Wed, Jul 19, 2017 at 09:21:57AM +0200, Lukas Czerner wrote: > > I am actually worried that with this approach we are, simply by adding > > complexity, making situation worse than just not running periodic > > e2fsck. > > How would it make things worse? If you don't trust lvm or dm-thin to > create a read-only snapshot, you've got **way** worse problems. I > acutally think relying on e2fsck on a r/o snapshot to be much simpler > than trying to add an on-line file systme check. That requires much > more kernel code which almost by definition is higher risk (e.g., to > bugs of the sort found by AFL) than already-existing userspace code. Because by adding complexity we're introducing bugs, problems and unexpected scenarios to what's supposed to be just a caution check. I feel like the problems caused by this setup are more likely than file system problems that would be caught by this check. But maybe I did not explain myself very well. I think that the dm-thin solution to run e2fsck is great, for those that already run dm-thin and those that are aware of what it means it's a great solution. But I was under assumption that we're talking about general recommendation - that's where I see the problem. It's not that I do not trust dm-thin, or lvm. They have their problems and bugs like everyone else. Not only that, but it comes with some caveats, like unresolved ENOSPC handling, or performance problems with legacy snapshots. It only takes to run a cron job in just the right time for the user to be terribly surprised. > > > What we should be aiming for I think is the online file system check and > > scrub. This would of course not replace the need rof e2fsck, but we > > would be able to catch errors early while fixing some of those that we > > can. But that's long term. Short term I think we're better off without > > this snapshotting/checking complexity. Those who are concerned can still > > enable the time/mount based checks right ? > > time/mount-based checks only help if you reboot; the advantage of > doing a check on read-only snapshot is you can schedule it once a > week, or once a month, during idle times. Picking idle times might be > tricky, but distro's when they decide on a default for running > updatedb(8) for the locate command. And whether the crontab entry is > installed by default, or has to be explicitly enabled by the user, or > e2croncheck is put in a separate package for distributions to use are > all distro decisions. > > I would probably go for the last, with a debian-style "recommends" or > "suggests" dependency for easy discoverability but different > distributions can do what they like --- including not packaging > e2croncheck at all. But in terms of a short-term solution it's really > not hard to add. And I don't believe I've heard any reports of > instability for r/o snapshot functionality. That's been around for a > long, long, time at least for LVM snapshots. dm-thin might be > considered more flakey, but that reputation seems to apply for dm-thin > as a whole, as opposed to just its snapshot functionality. If a user > is willing to trust their data to dm-thin, are taking a bigger risk by > using dm-thin snapshots? Right, for those that already use dm-thin that's, I thing, a good solution and it's easy enough to do. Having a distribution package to install to enable this is also fine. Even though my worry about this potentially causing more problems than it sovles still applies. Again, having this be a general recommendation (as it was the case with time/mount based checks) that's what I have much bigger problem with. Thanks! -Lukas > > - Ted
