* Theodore Ts'o <tytso@xxxxxxx>: > On Thu, Jul 13, 2017 at 11:17:03AM -0400, Eric Whitney wrote: > > ext4_remove_blocks() never returns anything other than 0, signifying > > success. Convert the function to void type to make this immediately > > obvious at the call site. > > > > Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> > > Actually, what we should do is to bubble errors up from > ext4_remove_blocks to the callers of ext4_ext_rm_leaf(). At the > moment it doesn't return any errors, but eventually we should be > returning errors all the way up to ext4 truncate. > > The reason why it's a little tricky is it's more than just not > deleting the call to ext4_std_error() and then returning error up to > the caller. We need to make sure that file system is in a > self-consistent state before we return an error up to the caller. > > Cheers, > > - Ted > OK, that confirms a suspicion I had. That looks more like a small project than a quick cleanup, so I'll withdraw the patch and perhaps revisit this in the future. Thanks, Eric
