Maybe diskaddr or just addr instead of physical which sounds a little confusing? Also how well was this tested? With all the calculation I'm a little worried about overflows, so a full xfstests run including sub-page blocksize and DAX really is in order here. > +#define IOMAP_F_INLINE 0x40 /* data mixed with metadata */ data inline in the inode?