________________________________________
From: Miao Xie [miaoxie@xxxxxxxxxx]
Sent: Thursday, July 06, 2017 11:51
To: Andreas Dilger; Wang Shilong
Cc: linux-ext4; Theodore Ts'o; Li Xi; zhangyi (F); Wang Shilong; Shuichi Ihara
Subject: Re: [PATCH v2 1/2] ext4, project: expand inode extra size if possible
Sorry, I reply late.
on 2017/7/6 at 0:31, Andreas Dilger wrote:
>>
>> + if (need_expand) {
>> + err = ext4_expand_extra_isize(inode,
>> + EXT4_SB(sb)->s_want_extra_isize,
>> + iloc, handle);
>> + if (err)
>> + goto out_stop;
>> + }
>> +
I found ext4_expand_extra_isize just tried to expand extra isize,
it would give up and return 0 if someone was holding attr lock.
so though it return 0, extra isize may not be expanded successfully.
---->yup, you are right, good point.
So ...
How about the following patches?
---->patches looks good for me, thanks for better fix and cleanup.
Thanks,
Shilong
