________________________________________ From: Miao Xie [miaoxie@xxxxxxxxxx] Sent: Monday, July 03, 2017 10:49 >> that file is dirtied(touch etc), changing project id will > <...SNIP...> > > ext4_expand_extra_isize should be invoked after ext4_reserve_inode_writ > > For changing projectid, we could know how many credits before start transaction.. I found most check in set_projectid is the same as ext4_mark_inode_dirty, so I think it's better to move those checks into ext4_expand_extra_isize to avoid the reduplicated code. ---> I agreed, it could reduce dubplicated codes, but again, ioctl failure is visible to common users, the behavior might be confusing for users? what kind of failure we should return to userspace? EAGAIN or EOVERFLOW? Thanks, Shilong
