On Fri, Jun 30, 2017 at 1:51 PM, Andreas Gruenbacher <agruenba@xxxxxxxxxx> wrote: > On Thu, Jun 29, 2017 at 3:54 PM, Christoph Hellwig <hch@xxxxxx> wrote: >> Switch to the iomap_seek_hole and iomap_seek_data helpers for >> implementing lseek SEEK_HOLE / SEEK_DATA, and remove all the >> code that isn't needed any more. >> >> Note that with this patch ext4 will now always depend on the iomap >> code instead of only when CONFIG_DAX is enabled, and it requires >> adding a call into the extent status tree for iomap_begin as well >> to properly deal with delalloc extents. > > This breaks SEEK_HOLE / SEEK_DATA on filesystems with the inline_data feature. > > Also, ext4 no longer calls inode_lock or inode_lock_shared; that needs > to be added back for consistency between reading i_size and walking > the file extents. Same on xfs, btw. Thanks, Andreas
