On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote: > On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@xxxxxxxxxx wrote: > > From: Jeff Layton <jlayton@xxxxxxxxxx> > > > > ext2 currently does a test+clear of the AS_EIO flag, which is > > is problematic for some coming changes. > > > > What we really need to do instead is call filemap_check_errors > > in __generic_file_fsync after syncing out the buffers. That > > will be sufficient for this case, and help other callers detect > > these errors properly as well. > > > > With that, we don't need to twiddle it in ext2. > > Seems like much of this code is getting replaced later in the > series.. It does. I suppose I could squash this in with the __generic_file_fsync patch. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
