Re: [PATCH 06/12] e2fsck: update i_blocks accounting for ea_inode feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2017 at 2:36 PM, Andreas Dilger <adilger@xxxxxxxxx> wrote:
> On Jun 26, 2017, at 7:43 AM, Tahsin Erdogan <tahsin@xxxxxxxxxx> wrote:
>>
>> With ea_inode feature, i_blocks include the disk space used by
>> referenced xattr inodes. Make e2fsck aware of that.
>
> This makes it all the more important that the "fast symlink" checking be
> divorced from i_blocks, and instead depend on i_size.  Otherwise, we will
> have yet another bunch of problems as large xattrs on a fast symlink will
> incorrectly result in problems with the symlink.
>
Totally agree. The changes to i_blocks accounting for ea_inode feature
likely broke ext4_inode_is_fast_symlink() in kernel. I will try to fix
that first.



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux