>> +#ifdef EXT2_NO_64_TYPE >> + fprintf(f, "%*u", width, ctx->num2); >> +#else >> + fprintf(f, "%*llu", width, (long long)ctx->num2); >> #endif > > Rather than a series of "#ifdef EXT2_NO_64_TYPE" checks, it would be cleaner > to have a single #define to set the printf type, like: > > #ifdef EXT2_NO_64_TYPE > #define EXT2_64U "%*u" > #define EXT2_64D "%*d" > #define EXT2_64X "%*x" > #else > #define EXT2_64U "%*llu" > #define EXT2_64D "%*lld" > #define EXT2_64X "%*llx" > #endif I am trying to figure out the purpose of #ifdef EXT2_NO_64_TYPE checks now. Who defines it and what problem does it solve? thanks