> On Jun 26, 2017, at 7:43 AM, Tahsin Erdogan <tahsin@xxxxxxxxxx> wrote: > > When check_inode_extra_space() detects a problem with the value of > i_extra_isize, it adjusts it and then returns without further validation > of contents in the inode body. Change this so that it will proceed to > check inline extended attributes. > > Signed-off-by: Tahsin Erdogan <tahsin@xxxxxxxxxx> > --- > e2fsck/pass1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c > index 32152f3ec926..1532fd2067f2 100644 > --- a/e2fsck/pass1.c > +++ b/e2fsck/pass1.c > @@ -582,7 +582,6 @@ static void check_inode_extra_space(e2fsck_t ctx, struct problem_context *pctx) > inode->i_extra_isize = (inode->i_extra_isize + 3) & ~3; > e2fsck_write_inode_full(ctx, pctx->ino, pctx->inode, > EXT2_INODE_SIZE(sb), "pass1"); > - return; > } > > /* check if there is no place for an EA header */ The problem is that if i_extra_isize is changed, then the EA magic and data will no longer be aligned properly, so there isn't anything to check? Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
