On Fri, Jun 16, 2017 at 03:34:10PM -0400, Jeff Layton wrote: > Resetting this flag is almost certainly racy, and will be problematic > with some coming changes. > > Make filemap_fdatawait_keep_errors return int, but not clear the flag(s). > Have jbd2 call it instead of filemap_fdatawait and don't attempt to > re-set the error flag if it fails. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > fs/jbd2/commit.c | 15 +++------------ > include/linux/fs.h | 2 +- > mm/filemap.c | 16 ++++++++++++++-- > 3 files changed, 18 insertions(+), 15 deletions(-) > I'm not too experienced with jbd2 internals, but this patch is clear enough: Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> -- Carlos
