Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return
From: Tahsin Erdogan <tahsin@xxxxxxxxxx>
Date: Fri, 23 Jun 2017 10:04:32 -0700
Cc: "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20170623145840.26779-1-colin.king@canonical.com>
References: <20170623145840.26779-1-colin.king@canonical.com>

On Fri, Jun 23, 2017 at 7:58 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> The error return ret is not set on a successful return path and
> so it returns a garbage value. Ensure it is is set to zero on
> a successful return.
Thanks for catching this bug!

Reviewed-by: Tahsin Erdogan <tahsin@xxxxxxxxxx>

References:
- [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return
  - From: Colin King

Prev by Date: Re: [PATCH 3/4] ubifs: don't bother checking for encryption key in ->mmap()
Next by Date: Re: [PATCH 3/4] ubifs: don't bother checking for encryption key in ->mmap()
Previous by thread: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return
Next by thread: Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]

Powered by Linux