Re: [PATCH] libext2fs: Fix fsync(2) detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 07, 2017 at 03:31:14PM +0200, Jan Kara wrote:
> For some reason lib/config.h.in was missing a definition of HAVE_FSYNC
> and as a result lib/config.h never had HAVE_FSYNC defined. As a result
> we never called fsync(2) for example from
> lib/ext2fs/unix_io.c:unix_flush() when we finished creating filesystem
> and could miss IO errors happening during creating of the filesystem.
> Test generic/405 exposes this problem.
> 
> Fix the problem by defining HAVE_FSYNC in lib/config.h.in.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Thanks for tracking down this regression.  This bug was introduced by
my cherry-picking in changes from the Android AOSP version of
e2fsprogs a few weeks ago.  I was wondering why generic/405 had
regressed.

Thanks, applied.

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux