Jan Kara <jack@xxxxxxx> wrote: > The callback doesn't ever get called. Remove it. Hmmm... I should perhaps be calling this. I'm not sure why I never did. At the moment, it doesn't strictly matter as ops on pages marked with PG_fscache get ignored if the cache has suffered an I/O error or has been withdrawn - but it will incur a performance penalty (the PG_fscache flag is checked in the netfs before calling into fscache). The downside of calling this is that when a cache is removed, fscache would go through all the cookies for that cache and iterate over all the pages associated with those cookies - which could cause a performance dip in the system. David
