Re: [PATCH] ext4: fix off-by-one error when writing back pages before dio read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 23, 2017 at 09:53:05AM +0200, Jan Kara wrote:
> On Mon 22-05-17 18:34:41, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> > 
> > The 'lend' argument of filemap_write_and_wait_range() is inclusive, so
> > we need to subtract 1 from pos + count.
> > 
> > Note that 'count' is guaranteed to be nonzero since
> > ext4_file_read_iter() returns early when given a 0 count.
> > 
> > Fixes: 16c54688592c ("ext4: Allow parallel DIO reads")
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Yeah. You can add:
> 
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Thanks, applied.

					- Ted



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux