In a later patch, we're going to want to make the fsync codepath not do a TestClearPageError call as that can override the error set in the address space. To do that though, we need to ensure that filesystems that are relying on the PG_error bit for reporting writeback errors also set an error in the address space. Ensure that this is set in nilfs2. Acked-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> --- fs/nilfs2/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index febed1217b3f..612d4b446793 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -1745,6 +1745,7 @@ static void nilfs_end_page_io(struct page *page, int err) } else { __set_page_dirty_nobuffers(page); SetPageError(page); + mapping_set_error(page_mapping(page), err); } end_page_writeback(page); -- 2.9.3