On Sun, Apr 30, 2017 at 12:26:05AM -0400, Theodore Ts'o wrote: > On Thu, Apr 27, 2017 at 10:36:40AM +0200, Lukas Czerner wrote: > > There is no need to call cond_resched() in ext4_trim_all_free() since > > blkdev_issue_discard() already takes care of that. So just remove it. > > Actually, it could be needed. If minblocks is a small value, say 2, > and every other block in file system is allocated, then we could be in > the while loop for a long time. That's a pretty unusual case, but > it's good to have the need_resched() check there. > > - Ted Fair enough, it's unusuall case, but still possible. Let's keep it this way. Thanks! -Lukas
