On Fri, Apr 28, 2017 at 11:59:34AM +0200, Jan Kara wrote: > Fix the problem by making sure journal superblock writes are always > treated as synchronous since they generally block progress of the > journalling machinery and thus the whole filesystem. The callchains leading down to jbd2_write_superblock looks a little suspicious to me. It seems like jbd2_journal_commit_transaction will actually call without FUA in the JBD2_FLUSHED case. Is that really intentional, and if yes should it be documented? Except for that it would seem more useful to move to a "bool preflush" argument passed down. But I guess we'll need a quick fix first, for that: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
