On 04/19/2017 01:39 AM, Christoph Hellwig wrote:
>
>> @@ -1593,6 +1593,11 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb,
>> }
>>
>> req->common.ki_flags |= iocb_rw_flags(iocb->aio_rw_flags);
>> + if ((req->common.ki_flags & IOCB_NOWAIT) &&
>> + !(req->common.ki_flags & IOCB_DIRECT)) {
>> + ret = -EINVAL;
>> + goto out_put_req;
>> + }
>
> Wrong indentation. Also I think this should be EOPNOTSUPP here.
>
Do we plan to add support for nowait in buffered I/O in the future? It
is just too complicated. EINVAL suits best in this case.
--
Goldwyn
