On Thu, Mar 02, 2017 at 02:44:13PM -0800, Darrick J. Wong wrote: > That's true. You're right in pointing out that dumpe2fs ought to be the > sole ext4 header dumping tool... but then there'll be complaints that > the online mode doesn't print the group descriptor information like the > offline mode does; also if I want to replicate dumpe2fs -h's output then > I basically have to export the whole ext4 superblock via ioctl (which > binds userspace to the ext4 superblock so dumpe2fs is likely to be the > only program ever to use it) to avoid complaints about the output > missing header fields; and finally combine that with the various > suggestions that I try to come up with some sort of generic fs geometry > ioctl, which (IMO) doesn't make enough sense to justify all the > inevitable fsdevel bikeshedding... Well, one advantage of using the ioctl is that it won't require special (root) privileges. So if we only use it when the block device can't be opened directly, it might still be useful, even if we don't return all of the information as dumpe2fs -h. > ...at that point I decided I just don't care anymore. I'll leave it to > whomever actually /does/ want this, since the original justification > (being able to hook up xfs_spaceman's reporting tools to ext4) is never > going to happen anyway. I'll take a look at this when I have a chance. I agree that integrating these two programs with e2freefrag and dumpe2fs makes the most amount of sense. - Ted
