On Fri, Feb 3, 2017 at 1:31 PM, Dave Jiang <dave.jiang@xxxxxxxxx> wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting the placement correctly. Removing the flag > values and introducing an input parameter to huge_fault that indicates > the size of the page entry. This makes the code easier to trace and > should avoid the issues we see with the fault flags where removal of the > flag was necessary in the fallback paths. > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> Tested-by: Dan Williams <dan.j.williams@xxxxxxxxx> This fixes a crash I can produce with the existing ndctl unit tests [1] on next-20170202. Now to go extend the tests to go after the PUD case... [1]: https://github.com/pmem/ndctl