Re: [PATCH] ext4: fix use-after-iput when fscrypt contexts are inconsistent

"Theodore Ts'o" <tytso@xxxxxxx> · Wed, 1 Feb 2017 21:17:36 -0500

On Tue, Jan 24, 2017 at 03:37:00PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> In the case where the child's encryption context was inconsistent with
> its parent directory, we were using inode->i_sb and inode->i_ino after
> the inode had already been iput().  Fix this by doing the iput() in the
> correct places.
> 
> Note: only ext4 had this bug, not f2fs and ubifs.
> 
> Fixes: d9cdc9033181 ("ext4 crypto: enforce context consistency")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Thanks, applied.

						- Ted