On Tue, Jan 24, 2017 at 01:27:22PM +0100, Jan Kara wrote: > I see, thanks for explanation. Well seeing all these problems with > ext4_expand_extra_isize() wouldn't we be better off by not calling it from > ext4_mark_inode_dirty() but rather explicitely from several well-defined > places? Because this implicit calling looks like it causes us too much > trouble. Yeah, I suppose that might be a better way to go. We could only do it on a file open, perhaps. It might not be as important it is to expand the extra_isize on, say, a chmod, for example. It's certainly worth looking to see whether it would simplify things to go that way. - Ted