Theodore Ts'o <tytso@xxxxxxx> writes: > On Wed, Dec 07, 2016 at 05:14:18PM +0400, Dmitry Monakhov wrote: >> Check what mke2fs will return non zero error on broken device. >> >> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx> > > Most developers don't run "make check" as root. So at minimum the > test should check to see if it is running as root, or be able to deal > with dmsetup failing due to permissions check. You right. There are number of reasons why dmsetup may fail (kernel is too old, no kernel compiled w/o DM). I'll send updated version. > > I wouldn't object if there was some environment variable, say SUDO or > DOROOT, which, if set, would prefix the commands which require root > with $DOROOT such that if the developer is willing to enable running > specific commands as root, that was allowed for the regression test. > > Alternatively the long-term plan that I have is to allow pathnames to > be specified using a URL-like scheme, e.g.; > > unix://path/to/filename > test://unix/path/to/filename > > Which would allow us to define a proper test mock I/O manager that > would allow for these sorts of tests without requiring root. > > Cheers, > > - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
