On Wed 02-11-16 07:27:46, Christoph Hellwig wrote: > On Tue, Nov 01, 2016 at 10:06:12PM +0100, Jan Kara wrote: > > Currently we don't allow unaligned writes without inode_lock. This is > > because zeroing of partial blocks could cause data corruption for racing > > unaligned writes to the same block. However DAX handles zeroing during > > block allocation and thus zeroing of partial blocks cannot race. Allow > > DAX unaligned IO to run without inode_lock. > > DAX writes should always take the inode lock. Without that you break > the expectations of existing applications that did not specify O_DIRECT. Yeah, actually this patch has no practical effect since later iomap conversion just effectively reverts this patch and I didn't realize it. I'll just drop it. Thanks. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html