On Fri 21-10-16 05:05:42, Christoph Hellwig wrote: > > + * Functionally, this is like unmap_underlying_metadata() for a range of > > + * blocks. It is implemented to be more efficient for larger ranges of blocks > > + * though. > > + */ > > +void unmap_underlying_metadata_ext(struct block_device *bdev, sector_t block, > > + sector_t len) > > Please explain what it does and why you'd call it. And while we're OK. > naming I think the 'metadata' part is highly confusing. What it does > is to clear buffers from the block device mapping, nothing about > metadata really. > > So how about unmap_buffers_range or similar? I can rename the function but I wanted to be consistent with unmap_underlying_metadata() function. It seems strange to have a function for a single block and a function for a range of blocks with very different names... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
