[PATCH] xfstests-bld: fix check script argument ordering bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The check script called by runtests.sh in the test appliance to control
xfstest execution requires that all optional arguments precede any test
names on its command line.  Violation of this requirement results in an
error message ("Arguments before tests, please!") and an immediate exit
without test execution.

runtests.sh violates this requirement when it runs a specific test in a
configuration that defines TEST_SET_EXCLUDE (contains -x argument).

To reproduce the bug, run "kvm-xfstests -c bigalloc generic/375".

Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
---
 kvm-xfstests/test-appliance/files/root/runtests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-xfstests/test-appliance/files/root/runtests.sh b/kvm-xfstests/test-appliance/files/root/runtests.sh
index a9338dc..5e6c1f7 100755
--- a/kvm-xfstests/test-appliance/files/root/runtests.sh
+++ b/kvm-xfstests/test-appliance/files/root/runtests.sh
@@ -374,7 +374,7 @@ do
 	gce_run_hooks fs-config-begin $i
 	for j in $(seq 1 $RPT_COUNT) ; do
 	    gce_run_hooks pre-xfstests $i $j
-	    bash ./check -T $AEX $FSTESTSET $TEST_SET_EXCLUDE
+	    bash ./check -T $AEX $TEST_SET_EXCLUDE $FSTESTSET
 	    gce_run_hooks post-xfstests $i $j
 	    umount "$TEST_DEV" >& /dev/null
 	    check_filesystem "$TEST_DEV" >& $RESULT_BASE/fsck.out
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux