Re: [PATCH] ext4: release bh in make_indexed_dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 30, 2016 at 01:36:30AM +0800, gmail wrote:
> The commit 6050d47adcad
> ("ext4: bail out from make_indexed_dir() on first error")
> miss to release bh in make_indexed_dir.
> 
> Signed-off-by: yangsheng <yngsion@xxxxxxxxx>

There's no missing brelse() as far as I can see.  bh is assigned to
frame->bh, and the call to dx_release(frames) will release bh.

	       	   	   		      	   - Ted

> ---
>  fs/ext4/namei.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 38ca0fe..465f960 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2058,19 +2058,18 @@ static int make_indexed_dir(handle_t *handle, struct ext4_filename *fname,
>  		retval = PTR_ERR(de);
>  		goto out_frames;
>  	}
> -	dx_release(frames);
>  
>  	retval = add_dirent_to_buf(handle, fname, dir, inode, de, bh);
> -	brelse(bh);
> -	return retval;
>  out_frames:
>  	/*
>  	 * Even if the block split failed, we have to properly write
>  	 * out all the changes we did so far. Otherwise we can end up
>  	 * with corrupted filesystem.
>  	 */
> -	ext4_mark_inode_dirty(handle, dir);
> +	if (retval)
> +		ext4_mark_inode_dirty(handle, dir);
>  	dx_release(frames);
> +	brelse(bh);
>  	return retval;
>  }
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux