Re: [PATCH] jbd2: Fix lockdep annotation in add_transaction_credits()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 19, 2016 at 02:30:43PM +0200, Jan Kara wrote:
> Thomas has reported a lockdep splat hitting in
> add_transaction_credits(). The problem is that that function calls
> jbd2_might_wait_for_commit() while holding j_state_lock which is wrong
> (we do not really wait for transaction commit while holding that lock).
> 
> Fix the problem by moving jbd2_might_wait_for_commit() into places where
> we are ready to wait for transaction commit and thus j_state_lock is
> unlocked.
> 
> Fixes: 1eaa566d368b214d99cbb973647c1b0b8102a9ae
> Reported-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux